Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the unified change stream spec tests to reflect that updateDescription.disambiguatedPaths should not be present unless showExpandedEvents is enabled, while explicitly excluding the server behavior regression in MongoDB 8.2.0.
Changes:
- Add a unified spec test asserting
disambiguatedPathsis absent whenshowExpandedEventsis false/unset, skipping server 8.2.0 via version gating. - Adjust
runOnRequirementstopologies in the YAML spec test file to match the updated coverage set. - Keep YAML and JSON variants of the unified spec test in sync.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/spec/change-streams/unified/change-streams-disambiguatedPaths.yml | Adds version-gated test ensuring disambiguatedPaths absence without showExpandedEvents; adjusts topologies list. |
| test/spec/change-streams/unified/change-streams-disambiguatedPaths.json | JSON equivalent of the added test and requirements to keep unified spec coverage aligned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Updated spec tests for change stream. All affected files pass tests, failures unrelated (even though they are also about change streams).
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript